Always use read-object hook during checkout #92
Conversation
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
|
This didn't repro in any of my local tests because we had the blobs in the shared object cache. |
|
Also - would it be possible to generate more diagnostic information around this workflow (or maybe that is just part of the work to flesh out the workflow)... It looks like we just write out that an error occurred, maybe there was some output on stderr that we could log. |
Signed-off-by: Derrick Stolee <stolee@gmail.com>
I think the proper test is to create a new, sparse clone using a local object cache. That prevents previous tests that ran a full prefetch from making the objects available. I'm going to try this out, but clone tests are particularly tricky (when they fail, the clone logs don't get output by the functional test machinery since the new clone enlistment is outside of the enlistment set up by the base class).
The latest commit adds the Git output and errors to the clone log file, but not to the user. |
|
Thanks for the quick turnaround! I think the extra logging will be helpful if we hit an error on this part of clone in the future |
| [TestCase] | ||
| public void SparseCloneWithNoPrefetchSucceeds() | ||
| { | ||
| string newEnlistmentRoot = ScalarFunctionalTestEnlistment.GetUniqueEnlistmentRoot(); |
There was a problem hiding this comment.
Could you call ScalarFunctionalTestEnlistment.CloneAndMountWithPerRepoCache here instead of manually setting up the clone?
| ProcessResult result = ProcessHelper.Run(processInfo); | ||
| result.ExitCode.ShouldEqual(0); | ||
|
|
||
| result = GitProcess.InvokeProcess(Path.Combine(newEnlistmentRoot, "src"), "status"); |
There was a problem hiding this comment.
If you're able to use CloneAndMountWithPerRepoCache you could use enlistment.RepoRoot here instead of Path.Combine(newEnlistmentRoot, "src")
| ScalarFunctionalTestEnlistment enlistment = ScalarFunctionalTestEnlistment.CloneAndMountWithPerRepoCache(ScalarTestConfig.PathToScalar, skipPrefetch: true); | ||
|
|
||
| ProcessResult result = GitProcess.InvokeProcess(enlistment.RepoRoot, "status"); | ||
| result.ExitCode.ShouldEqual(0, result.Errors); |
There was a problem hiding this comment.
I think you should call UnmountAndDeleteAll at the end here (or in a try/finally)
There was a problem hiding this comment.
Sorry to clarify, enlistment.UnmountAndDeleteAll (and apologies for missing that with the earlier suggestion)
Signed-off-by: Derrick Stolee <stolee@gmail.com>
Thanks for the help with these tests! Unfamiliar territory for me here. :D |
While refactoring the
CloneVerbin #77, I moved thegit checkout -fcommand to the end of clone, as needed. This is because we will actually fill out blobs during this initial checkout.However, there was one slight problem: we need the read-object hook. There are two ways to do a checkout in the
GitProcess, and one was not allowing the read-object hook.Before #77, this checkout was called before the mount was ready, but that's no longer important.
Thanks @jamill for finding this bug!